From 9eb0f53db1ae87058458eae267f2a72e3a0a8091 Mon Sep 17 00:00:00 2001
From: scatterflower <2956568+scatterflower@users.noreply.github.com>
Date: Wed, 19 Aug 2020 16:40:37 -0500
Subject: Reset BASS when switching devices; drop Qt Multimedia support (#262)

* Allow changing audio device on the fly while in a server
* Use default audio device if device in config doesn't exist
* Automatically change audio device to default when current one is invalid
* Destroy Qt Multimedia support

It was decided that there was not enough attention being given to Qt
Multimedia support to justify its continued maintenance simply as a
libre alternative to BASS. While substantial changes to audio were being
made in 2.8, the Qt Multimedia support code fell behind in disrepair.
It's clear that there is no vested interest in implementing audio
features twice for the sake of licensing.

When it's time to switch to another audio library, it will be done
unilaterally.

* CI: Use BASS for Linux build

Co-authored-by: oldmud0 <oldmud0@users.noreply.github.com>
---
 src/lobby.cpp | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

(limited to 'src/lobby.cpp')

diff --git a/src/lobby.cpp b/src/lobby.cpp
index 3aa488ad..093b0f7d 100644
--- a/src/lobby.cpp
+++ b/src/lobby.cpp
@@ -5,6 +5,8 @@
 #include "debug_functions.h"
 #include "networkmanager.h"
 
+#include <QImageReader>
+
 Lobby::Lobby(AOApplication *p_ao_app) : QMainWindow()
 {
   ao_app = p_ao_app;
@@ -353,13 +355,7 @@ void Lobby::on_connect_released()
 
 void Lobby::on_about_clicked()
 {
-#ifdef BASSAUDIO
-  const QString audio = "BASS";
-#elif defined(QTAUDIO)
-  const QString audio = "Qt Multimedia";
-#else
-  const QString audio = "null";
-#endif
+  const bool hasApng = QImageReader::supportedImageFormats().contains("APNG");
 
   QString msg =
       tr("<h2>Attorney Online %1</h2>"
@@ -389,11 +385,12 @@ void Lobby::on_about_clicked()
          "is copyright (c) 2016-2020 Attorney Online developers. Open-source "
          "licenses apply. All other assets are the property of their "
          "respective owners."
-         "<p>Running on Qt version %2 with the %3 audio engine."
+         "<p>Running on Qt version %2 with the BASS audio engine.<br>"
+         "APNG plugin loaded: %3"
          "<p>Built on %4")
       .arg(ao_app->get_version_string())
       .arg(QLatin1String(QT_VERSION_STR))
-      .arg(audio)
+      .arg(hasApng ? tr("Yes") : tr("No"))
       .arg(QLatin1String(__DATE__));
   QMessageBox::about(this, tr("About"), msg);
 }
-- 
cgit