From ba03fb03e238b87dac4720a59bf961a4a13fd869 Mon Sep 17 00:00:00 2001
From: sD <stoned@derpymail.org>
Date: Fri, 13 Mar 2020 16:22:41 +0100
Subject: musictime is a bad name for this

---
 src/packet_distribution.cpp | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

(limited to 'src/packet_distribution.cpp')

diff --git a/src/packet_distribution.cpp b/src/packet_distribution.cpp
index 5e17542d..da59c202 100644
--- a/src/packet_distribution.cpp
+++ b/src/packet_distribution.cpp
@@ -411,7 +411,7 @@ void AOApplication::server_packet_received(AOPacket *p_packet)
     if (!courtroom_constructed)
       goto end;
 
-    bool musics_time = false;
+    bool musiclist_start = false;
     int areas = 0;
 
     for (int n_element = 0 ; n_element < f_contents.size() ; n_element += 2)
@@ -428,7 +428,7 @@ void AOApplication::server_packet_received(AOPacket *p_packet)
 
       w_lobby->set_loading_text(tr("Loading music:\n%1/%2").arg(QString::number(loaded_music)).arg(QString::number(music_list_size)));
 
-      if (musics_time)
+      if (musiclist_start)
       {
           w_courtroom->append_music(f_music);
       }
@@ -440,7 +440,7 @@ void AOApplication::server_packet_received(AOPacket *p_packet)
                   f_music.endsWith(".ogg") ||
                   f_music.endsWith(".opus"))
           {
-              musics_time = true;
+              musiclist_start = true;
               areas--;
               //w_courtroom->fix_last_area();
               w_courtroom->append_music(f_music);
@@ -514,22 +514,22 @@ void AOApplication::server_packet_received(AOPacket *p_packet)
       if (!courtroom_constructed)
             goto end;
 
-          bool musics_time = false;
+          bool musiclist_start = false;
           area_count = 0;
 
           for (int n_element = 0 ; n_element < f_contents.size() ; ++n_element)
           {
-            if (!musics_time && (f_contents.at(n_element).startsWith("==") ||
+            if (!musiclist_start && (f_contents.at(n_element).startsWith("==") ||
                                  f_contents.at(n_element).endsWith(".wav") ||
                                  f_contents.at(n_element).endsWith(".mp3") ||
                                  f_contents.at(n_element).endsWith(".mp4") ||
                                  f_contents.at(n_element).endsWith(".ogg") ||
                                  f_contents.at(n_element).endsWith(".opus")))
             {
-                musics_time = true;
+                musiclist_start = true;
                 continue;
             }
-            AOPacketLoadMusicThreading *music_load = new AOPacketLoadMusicThreading(this, f_contents.at(n_element), musics_time);
+            AOPacketLoadMusicThreading *music_load = new AOPacketLoadMusicThreading(this, f_contents.at(n_element), musiclist_start);
             QThreadPool::globalInstance()->start(music_load);
             ++loaded_music;
             int total_loading_size = char_list_size * 2 + evidence_list_size + music_list_size;
-- 
cgit 


From 1b0930b977b5e7ee1b7bd1c7eeb9625702d928e3 Mon Sep 17 00:00:00 2001
From: sD <stoned@derpymail.org>
Date: Fri, 13 Mar 2020 16:29:01 +0100
Subject: move area list detection algorithm into a seperate function

---
 src/packet_distribution.cpp | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

(limited to 'src/packet_distribution.cpp')

diff --git a/src/packet_distribution.cpp b/src/packet_distribution.cpp
index da59c202..9f072ae9 100644
--- a/src/packet_distribution.cpp
+++ b/src/packet_distribution.cpp
@@ -151,6 +151,16 @@ void AOApplication::ms_packet_received(AOPacket *p_packet)
   delete p_packet;
 }
 
+bool AOApplication::is_music_track(QString trackname)
+{
+    return (trackname.startsWith("==") ||
+            trackname.endsWith(".wav") ||
+            trackname.endsWith(".mp3") ||
+            trackname.endsWith(".mp4") ||
+            trackname.endsWith(".ogg") ||
+            trackname.endsWith(".opus"));
+}
+
 void AOApplication::server_packet_received(AOPacket *p_packet)
 {
   p_packet->net_decode();
@@ -434,11 +444,7 @@ void AOApplication::server_packet_received(AOPacket *p_packet)
       }
       else
       {
-          if (f_music.endsWith(".wav") ||
-                  f_music.endsWith(".mp3") ||
-                  f_music.endsWith(".mp4") ||
-                  f_music.endsWith(".ogg") ||
-                  f_music.endsWith(".opus"))
+          if (is_music_track(f_music))
           {
               musiclist_start = true;
               areas--;
@@ -519,12 +525,7 @@ void AOApplication::server_packet_received(AOPacket *p_packet)
 
           for (int n_element = 0 ; n_element < f_contents.size() ; ++n_element)
           {
-            if (!musiclist_start && (f_contents.at(n_element).startsWith("==") ||
-                                 f_contents.at(n_element).endsWith(".wav") ||
-                                 f_contents.at(n_element).endsWith(".mp3") ||
-                                 f_contents.at(n_element).endsWith(".mp4") ||
-                                 f_contents.at(n_element).endsWith(".ogg") ||
-                                 f_contents.at(n_element).endsWith(".opus")))
+            if (!musiclist_start && is_music_track(f_contents.at(n_element)))
             {
                 musiclist_start = true;
                 continue;
-- 
cgit