| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 5 days | Remove toLowerCase mangling | Osmium Sorcerer | |
| For whatever reason, WebAO decides to normalize almost every string component in URLs, packets, and INI files to lower case. First, the glaring issue. In the URLs, this handling of paths is utterly broken and corrupts data. By mangling characters, you change the resource identity and break valid URLs. According to section 6.2.2.1 of RFC 3986 (Case Normalization): > When a URI uses components of the generic syntax, the component syntax > equivalence rules always apply; namely, that the scheme and host are > case-insensitive and therefore should be normalized to lowercase. For > example, the URI <HTTP://www.EXAMPLE.com/> is equivalent to > <http://www.example.com/>. The other generic syntax components are > assumed to be case-sensitive unless specifically defined otherwise by > the scheme (see Section 6.2.3) Scheme and host _are_ case-insensitive. Path is _not_, so isn't everything else. Section 6.2.3 doesn't define any normalization for the path component in HTTP schemes. Thus, example.com/item and example.com/Item are two different resources. I can only think of idiotic conventions of a particular poorly designed file system when it comes to this absurdity. There's no reason to drag them around in our developments. For these systems, case doesn't matter anyway, normalization is their job, not server hosts' who end up having to either rewrite every URL request for every asset, or mangle their asset directory and then rewrite almost every INI config (and spam "showname=Name" everywhere because now your character directory has to be "name"). So, instead of using absurd ad-hoc solutions to a broken implementation such as forcing everything to lower case on the server side, this commit attempts to fix the root issue and make URL handling conformant to relevant standards. Similar situation with strings within packets, although not as severe in practice. Case must be preserved, otherwise it's corrupting data for no reason. If a normalization is needed, it should be done at the call site of whatever requires it (like a filtering function), not by the parser. As for the INI, it's opinionated. While the values absolutely must not be normalized, a case can be made for keys and section names: why not allow "Options", "options", or even "oPtiOnS"? It's more convenient, and corresponds to the platform quirk of Windows (which Qt unfortunately inherits in AO2 Client). I don't think there's a good reason to allow such leniency in parsing, and removing superfluous normalization is a better move: less data transformations, less ambiguity, more strictness. In practice, INIs tend to be well-formed, and it's good discipline to write them this way. In several places, the case-folding does make sense: callwords, OOC commands, CSS class names for areas, and character list filters. These will behave weirdly and inconveniently without it. In most places, however, it only causes unnecessary breakage. | |||
| 2026-03-28 | remove UI related changes | David Skoland | |
| 2026-03-24 | signature | David Skoland | |
| 2026-03-24 | add comment explaining assumption | David Skoland | |
| 2026-03-24 | Add reconnect UI, disconnect button, and visual cleanup | David Skoland | |
| - Redesign disconnect overlay as a full-screen modal with dark backdrop - Add working Reconnect button that properly re-establishes WebSocket connection - Add Disconnect button in Settings for testing - Separate disconnect and ban/kick codepaths (no reconnect on ban) - Log disconnect notice in IC log using hrtext style - Refactor area list rendering from client state (renderAreaList) - Extract appendICNotice for reusable IC log notices - Clean up charselect: hide during loading, simplify toolbar layout - Freshen loading screen and charselect styling - Remove loading progress text updates (just show "Loading...") - Guard against undefined client.chars and client.serv Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> | |||
| 2026-02-11 | Clamp playerlist char icons to 60x60 pixels | David Skoland | |
| Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> | |||
| 2026-02-11 | Filter playerlist by area and remove Area column | David Skoland | |
| Hide players not in the client's current area. Re-render playerlist on area switch. Remove the now-redundant Area column. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> | |||
| 2026-02-11 | Add area column to playerlist | David Skoland | |
| Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> | |||
| 2026-02-10 | Use charName directly for playerlist rendering and add table styling | David Skoland | |
| Render char icons and names from the character name string (PU type 1) instead of gating on charId lookup. Add header row and row separators to the playerlist table. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> | |||
| 2026-02-10 | Refactor playerlist to state-driven rendering with renderPlayerList | David Skoland | |
| handlePR and handlePU now only update client.playerlist state, and renderPlayerList handles all DOM rendering from that state. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> | |||
| 2026-02-07 | Prefetch char.ini for characters present in area via playerlist | David Skoland | |
| Store player data (charId, area) in an in-memory Map on the client, updated by PR/PU packet handlers. Use this to eagerly load char.ini when a player's character appears in our area or when switching areas, eliminating the lazy-load delay on first IC message. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> | |||
| 2025-10-02 | use the file for previews | stonedDiscord | |
| 2025-09-03 | also do bgs | stonedDiscord | |
| 2025-09-03 | bgurls | stonedDiscord | |
| 2025-06-26 | convert vol to ts | stonedDiscord | |
| 2024-12-12 | Prettified Code! | stonedDiscord | |
| 2024-12-12 | akashi expects 2 args for modcalls | stonedDiscord | |
| 2024-11-20 | Prettified Code! | stonedDiscord | |
| 2024-11-20 | Prettified Code! | stonedDiscord | |
| 2024-08-31 | hide out of area players | stonedDiscord | |
| 2024-08-31 | playerlist fixes | stonedDiscord | |
| 2024-08-12 | Merge pull request #225 from AttorneyOnline/playerlist | stonedDiscord | |
| Playerlist | |||
| 2024-08-08 | more off by one | stonedDiscord | |
| 2024-08-08 | another off by one | stonedDiscord | |
| 2024-08-07 | correct units | stonedDiscord | |
| 2024-08-07 | add ban button | stonedDiscord | |
| 2024-04-12 | name spacing | stonedDiscord | |
| 2023-12-08 | rename callback | stonedDiscord | |
| 2023-12-08 | throw out google | stonedDiscord | |
| 2023-10-17 | Focus input box when emotion is picked | David Skoland | |
| 2023-09-20 | autoformat with eslint | stonedDiscord | |
| 2023-09-20 | no more eslint errors | stonedDiscord | |
| 2023-09-20 | make eslint a lot happier | stonedDiscord | |
| 2023-06-06 | fix clannad clock | stonedDiscord | |
| 2023-04-25 | minor spelling mistake | stonedDiscord | |
| 2023-04-25 | forgot import | stonedDiscord | |
| 2023-04-25 | check for animated bgs in preview | stonedDiscord | |
| 2023-01-23 | bring mute back | stonedDiscord | |
| 2022-12-07 | remove chat from chatbox names | stonedDiscord | |
| 2022-11-22 | where did this bracket come from | stonedDiscord | |
| 2022-11-18 | fix iniedit input box | stonedDiscord | |
| 2022-11-17 | :spaghetti: :spaghetti: :spaghetti: :spaghetti: :spaghetti: :spaghetti: ↵ | stonedDiscord | |
| :spaghetti: | |||
| 2022-11-17 | copypasta :spaghetti: | stonedDiscord | |
| 2022-11-17 | both ini dropdown and custom | stonedDiscord | |
| 2022-11-17 | rename to iniselect | stonedDiscord | |
| 2022-11-13 | bring back iniedit dropdown | stonedDiscord | |
| 2022-11-11 | more console spam | stonedDiscord | |
| 2022-10-22 | whoops forgot args are a list | stonedDiscord | |
| 2022-10-22 | this is much nicer | stonedDiscord | |
| 2022-10-22 | show the dialog | stonedDiscord | |
 |
index : webao | |
| WebAO fork | Osmium Sorcerer |
| aboutsummaryrefslogtreecommitdiff |