aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSalanto <62221668+Salanto@users.noreply.github.com>2021-12-15 03:32:05 +0100
committerGitHub <noreply@github.com>2021-12-14 20:32:05 -0600
commit641cca65044e41e49e5a871f0d60138b61c1bab3 (patch)
tree702a50567cfe2ddd25b66b40542f233cc00eae04
parentc8f99bd904d5f2feb8fb4fa3963c96993415ded4 (diff)
Add compiler flags to ensure correct signal is used in older versions (#617)
-rw-r--r--src/networkmanager.cpp42
1 files changed, 31 insertions, 11 deletions
diff --git a/src/networkmanager.cpp b/src/networkmanager.cpp
index 8a90b7c9..08d01242 100644
--- a/src/networkmanager.cpp
+++ b/src/networkmanager.cpp
@@ -45,11 +45,17 @@ void NetworkManager::connect_to_master()
void NetworkManager::connect_to_master_nosrv()
{
- connect(ms_socket, &QTcpSocket::errorOccurred, this,
- &NetworkManager::on_ms_socket_error);
+#if QT_VERSION < QT_VERSION_CHECK(5, 15, 0)
+ connect(ms_socket, QOverload<QAbstractSocket::SocketError>::of(&QAbstractSocket::error),
+ this, &NetworkManager::on_ms_socket_error);
+#else
+ connect(ms_socket, &QTcpSocket::errorOccurred,
+ this, &NetworkManager::on_ms_socket_error);
+#endif
+
+ connect(ms_socket, &QTcpSocket::connected,
+ this, &NetworkManager::on_ms_nosrv_connect_success);
- connect(ms_socket, &QTcpSocket::connected, this,
- &NetworkManager::on_ms_nosrv_connect_success);
ms_socket->connectToHost(ms_nosrv_hostname, ms_port);
}
@@ -155,9 +161,13 @@ void NetworkManager::on_srv_lookup()
if (connected) {
// Connect a one-shot signal in case the master server disconnects
// randomly
- connect(
- ms_socket, &QTcpSocket::errorOccurred, this,
- &NetworkManager::on_ms_socket_error);
+#if QT_VERSION < QT_VERSION_CHECK(5, 15, 0)
+ connect(ms_socket, QOverload<QAbstractSocket::SocketError>::of(&QAbstractSocket::error),
+ this, &NetworkManager::on_ms_socket_error);
+#else
+ connect(ms_socket, &QTcpSocket::errorOccurred,
+ this, &NetworkManager::on_ms_socket_error);
+#endif
break;
}
else {
@@ -182,8 +192,13 @@ void NetworkManager::on_ms_nosrv_connect_success()
disconnect(ms_socket, &QTcpSocket::connected, this,
&NetworkManager::on_ms_nosrv_connect_success);
- connect(ms_socket, &QTcpSocket::errorOccurred, this,
- &NetworkManager::on_ms_socket_error);
+#if QT_VERSION < QT_VERSION_CHECK(5, 15, 0)
+ connect(ms_socket, QOverload<QAbstractSocket::SocketError>::of(&QAbstractSocket::error),
+ this, &NetworkManager::on_ms_socket_error);
+#else
+ connect(ms_socket, &QTcpSocket::errorOccurred,
+ this, &NetworkManager::on_ms_socket_error);
+#endif
}
void NetworkManager::on_ms_socket_error(QAbstractSocket::SocketError error)
@@ -193,8 +208,13 @@ void NetworkManager::on_ms_socket_error(QAbstractSocket::SocketError error)
// Disconnect the one-shot signal - this way, failover connect attempts
// don't trigger a full retry
- disconnect(ms_socket, &QTcpSocket::errorOccurred, this,
- &NetworkManager::on_ms_socket_error);
+#if QT_VERSION < QT_VERSION_CHECK(5, 15, 0)
+ disconnect(ms_socket, QOverload<QAbstractSocket::SocketError>::of(&QAbstractSocket::error),
+ this, &NetworkManager::on_ms_socket_error);
+#else
+ disconnect(ms_socket, &QTcpSocket::errorOccurred,
+ this, &NetworkManager::on_ms_socket_error);
+#endif
emit ms_connect_finished(false, true);