Ported to CMake, ...

* Ported the project to CMake
  * Android and Mac support dropped for the time
being.
  * Tests, BASS and Discord-RPC are now options
* Restructured and reformated the project.
  * Merged `include` and `src`
  * Renamed `resource` to `data`
  * Renamed various files
  * External libraries headers are no longer included in `src`
  * Replaced header guards with #pragma once
  * Multiple refactors (keywords, headers)
  * Added Qt6 compatibility
* Removed various unused functions and headers
* Reworked AOPacket
  * When content is passed to AOPacket, it should be ensured that the content is already decoded.
  * Encoding/decoding are now static methods.
* Fixed various memory leaks
* Removed animation code for AOImage
  * AOImage is always using static images
* Simplified ChatLogPiece

1 files changed, 226 insertions, 189 deletions

diff --git a/src/text_file_functions.cpp b/src/text_file_functions.cpp
index 51dc95ad..d8d0c61c 100644
--- a/src/text_file_functions.cpp
+++ b/src/text_file_functions.cpp
@@ -1,7 +1,16 @@
-#include "text_file_functions.h"
+#include "aoapplication.h"
+
 #include "aoutils.h"
+#include "file_functions.h"
 #include "options.h"
 
+#include <QColor>
+#include <QDebug>
+#include <QSettings>
+#include <QStringList>
+#include <QTextStream>
+#include <QVector>
+
 QStringList AOApplication::get_list_file(VPath path)
 {
   return get_list_file(get_real_path(path));
@@ -16,11 +25,14 @@ QStringList AOApplication::get_list_file(QString p_file)
   p_ini.setFileName(p_file);
 
   if (!p_ini.open(QIODevice::ReadOnly))
+  {
     return return_value;
+  }
 
   QTextStream in(&p_ini);
 
-  while (!in.atEnd()) {
+  while (!in.atEnd())
+  {
     QString line = in.readLine();
     return_value.append(line);
   }
@@ -31,11 +43,14 @@ QStringList AOApplication::get_list_file(QString p_file)
 QString AOApplication::read_file(QString filename)
 {
   if (filename.isEmpty())
+  {
     return QString();
+  }
 
   QFile f_log(filename);
 
-  if (!f_log.open(QIODevice::ReadOnly | QIODevice::Text)) {
+  if (!f_log.open(QIODevice::ReadOnly | QIODevice::Text))
+  {
     qWarning() << "Couldn't open" << filename << "for reading";
     return QString();
   }
@@ -49,17 +64,22 @@ QString AOApplication::read_file(QString filename)
 bool AOApplication::write_to_file(QString p_text, QString p_file, bool make_dir)
 {
   QString path = QFileInfo(p_file).path();
-  if (make_dir) {
+  if (make_dir)
+  {
     // Create the dir if it doesn't exist yet
     QDir dir(path);
     if (!dir.exists())
+    {
       if (!dir.mkpath("."))
+      {
         return false;
+      }
+    }
   }
 
   QFile f_log(p_file);
-  if (f_log.open(QIODevice::WriteOnly | QIODevice::Text |
-                 QIODevice::Truncate)) {
+  if (f_log.open(QIODevice::WriteOnly | QIODevice::Text | QIODevice::Truncate))
+  {
     QTextStream out(&f_log);
 
 #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
@@ -74,24 +94,29 @@ bool AOApplication::write_to_file(QString p_text, QString p_file, bool make_dir)
   return false;
 }
 
-bool AOApplication::append_to_file(QString p_text, QString p_file,
-                                   bool make_dir)
+bool AOApplication::append_to_file(QString p_text, QString p_file, bool make_dir)
 {
-  if(!file_exists(p_file)) //Don't create a newline if file didn't exist before now
+  if (!file_exists(p_file)) // Don't create a newline if file didn't exist before now
   {
     return write_to_file(p_text, p_file, make_dir);
   }
   QString path = QFileInfo(p_file).path();
   // Create the dir if it doesn't exist yet
-  if (make_dir) {
+  if (make_dir)
+  {
     QDir dir(path);
     if (!dir.exists())
+    {
       if (!dir.mkpath("."))
+      {
         return false;
+      }
+    }
   }
 
   QFile f_log(p_file);
-  if (f_log.open(QIODevice::WriteOnly | QIODevice::Append)) {
+  if (f_log.open(QIODevice::WriteOnly | QIODevice::Append))
+  {
     QTextStream out(&f_log);
 
 #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
@@ -108,41 +133,43 @@ bool AOApplication::append_to_file(QString p_text, QString p_file,
 
 QMultiMap<QString, QString> AOApplication::load_demo_logs_list() const
 {
-    QString l_log_path = applicationDirPath() + "/logs/";
-    QDir l_log_folder(l_log_path);
-    l_log_folder.setFilter(QDir::NoDotAndDotDot | QDir::Dirs);
+  QString l_log_path = applicationDirPath() + "/logs/";
+  QDir l_log_folder(l_log_path);
+  l_log_folder.setFilter(QDir::NoDotAndDotDot | QDir::Dirs);
 
-    QMultiMap<QString,QString> l_demo_logs;
-    for (const QString &l_demo_folder_name : l_log_folder.entryList()) {
-        QDir l_demo_folder(l_log_path + l_demo_folder_name);
-        l_demo_folder.setFilter(QDir::Files);
-        l_demo_folder.setNameFilters(QStringList() << "*.demo");
+  QMultiMap<QString, QString> l_demo_logs;
+  for (const QString &l_demo_folder_name : l_log_folder.entryList())
+  {
+    QDir l_demo_folder(l_log_path + l_demo_folder_name);
+    l_demo_folder.setFilter(QDir::Files);
+    l_demo_folder.setNameFilters(QStringList() << "*.demo");
 
-        for (QString l_demo_name : l_demo_folder.entryList()) {
-            l_demo_logs.insert(l_demo_folder_name, l_demo_name);
-        }
+    for (QString l_demo_name : l_demo_folder.entryList())
+    {
+      l_demo_logs.insert(l_demo_folder_name, l_demo_name);
     }
-    return l_demo_logs;
+  }
+  return l_demo_logs;
 }
 
-QString AOApplication::read_design_ini(QString p_identifier,
-                                       VPath p_design_path)
+QString AOApplication::read_design_ini(QString p_identifier, VPath p_design_path)
 {
   return read_design_ini(p_identifier, get_real_path(p_design_path));
 }
 
-QString AOApplication::read_design_ini(QString p_identifier,
-                                       QString p_design_path)
+QString AOApplication::read_design_ini(QString p_identifier, QString p_design_path)
 {
   QSettings settings(p_design_path, QSettings::IniFormat);
 #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
   settings.setIniCodec("UTF-8");
 #endif
   QVariant value = settings.value(p_identifier);
-  if (value.type() == QVariant::StringList) {
+  if (value.type() == QVariant::StringList)
+  {
     return value.toStringList().join(",");
   }
-  else if (!value.isNull()) {
+  else if (!value.isNull())
+  {
     return value.toString();
   }
   return "";
@@ -151,10 +178,14 @@ QString AOApplication::read_design_ini(QString p_identifier,
 Qt::TransformationMode AOApplication::get_scaling(QString p_scaling)
 {
   if (p_scaling.isEmpty())
+  {
     p_scaling = Options::getInstance().defaultScalingMode();
+  }
 
   if (p_scaling == "smooth")
+  {
     return Qt::SmoothTransformation;
+  }
   return Qt::FastTransformation;
 }
 
@@ -167,21 +198,23 @@ QPoint AOApplication::get_button_spacing(QString p_identifier, QString p_file)
   return_value.setY(0);
 
   if (value == "")
+  {
     return return_value;
+  }
 
   QStringList sub_line_elements = value.split(",");
 
   if (sub_line_elements.size() < 2)
+  {
     return return_value;
+  }
   return_value.setX(sub_line_elements.at(0).toInt() * Options::getInstance().themeScalingFactor());
   return_value.setY(sub_line_elements.at(1).toInt() * Options::getInstance().themeScalingFactor());
 
   return return_value;
 }
 
-pos_size_type AOApplication::get_element_dimensions(QString p_identifier,
-                                                    QString p_file,
-                                                    QString p_misc)
+pos_size_type AOApplication::get_element_dimensions(QString p_identifier, QString p_file, QString p_misc)
 {
   pos_size_type return_value;
   return_value.x = 0;
@@ -193,7 +226,9 @@ pos_size_type AOApplication::get_element_dimensions(QString p_identifier,
   QStringList sub_line_elements = f_result.split(",");
 
   if (sub_line_elements.size() < 4)
+  {
     return return_value;
+  }
 
   int scale = Options::getInstance().themeScalingFactor();
 
@@ -204,36 +239,32 @@ pos_size_type AOApplication::get_element_dimensions(QString p_identifier,
 
   return return_value;
 }
-QString AOApplication::get_design_element(QString p_identifier, QString p_file,
-                                          QString p_misc)
+QString AOApplication::get_design_element(QString p_identifier, QString p_file, QString p_misc)
 {
   QString value = get_config_value(p_identifier, p_file, Options::getInstance().theme(), Options::getInstance().subTheme(), default_theme, p_misc);
   if (!value.isEmpty())
+  {
     return value;
+  }
   return "";
 }
 
-// tfw this function is only used for lobby and nowhere else
-int AOApplication::get_font_size(QString p_identifier, QString p_file)
-{
-  QString value = get_config_value(p_identifier, p_file, Options::getInstance().theme(), Options::getInstance().subTheme(), default_theme);
-  if (!value.isEmpty())
-    return value.toInt();
-  return 10;
-}
-
 QColor AOApplication::get_color(QString p_identifier, QString p_file)
 {
   QString value = get_config_value(p_identifier, p_file, Options::getInstance().theme(), Options::getInstance().subTheme(), default_theme);
   QColor return_color(0, 0, 0);
 
   if (value.isEmpty())
+  {
     return return_color;
+  }
 
   QStringList color_list = value.split(",");
 
   if (color_list.size() < 3)
+  {
     return return_color;
+  }
 
   return_color.setRed(color_list.at(0).toInt());
   return_color.setGreen(color_list.at(1).toInt());
@@ -248,47 +279,17 @@ QString AOApplication::get_stylesheet(QString p_file)
   QFile design_ini;
   design_ini.setFileName(path);
   if (!design_ini.open(QIODevice::ReadOnly))
+  {
     return "";
-
-  QTextStream in(&design_ini);
-
-  QString f_text;
-
-  while (!in.atEnd()) {
-    f_text.append(in.readLine());
   }
 
-  design_ini.close();
-  return f_text;
-}
-
-QString AOApplication::get_tagged_stylesheet(QString target_tag, QString p_file)
-{
-  QString path = get_asset(p_file, Options::getInstance().theme(), Options::getInstance().subTheme(), default_theme);
-  QFile design_ini;
-  design_ini.setFileName(path);
-  if (!design_ini.open(QIODevice::ReadOnly))
-    return "";
-
   QTextStream in(&design_ini);
 
   QString f_text;
 
-  bool tag_found = false;
-
-  while (!in.atEnd()) {
-    QString line = in.readLine();
-
-    if (line.startsWith(target_tag, Qt::CaseInsensitive)) {
-      tag_found = true;
-      continue;
-    }
-
-    if (tag_found) {
-      if ((line.startsWith("[") && line.endsWith("]")))
-        break;
-      f_text.append(line);
-    }
+  while (!in.atEnd())
+  {
+    f_text.append(in.readLine());
   }
 
   design_ini.close();
@@ -300,19 +301,18 @@ QString AOApplication::get_chat_markup(QString p_identifier, QString p_chat)
   // New Chadly method
   QString value = get_config_value(p_identifier, "chat_config.ini", Options::getInstance().theme(), Options::getInstance().subTheme(), default_theme, p_chat);
   if (!value.isEmpty())
+  {
     return value.toUtf8();
+  }
 
   // Backwards ass compatibility
-  QVector<VPath> backwards_paths {
-    get_theme_path("misc/" + p_chat + "/config.ini"),
-    VPath("misc/" + p_chat + "/config.ini"),
-    get_theme_path("misc/default/config.ini"),
-    VPath("misc/default/config.ini")
-  };
+  QVector<VPath> backwards_paths{get_theme_path("misc/" + p_chat + "/config.ini"), VPath("misc/" + p_chat + "/config.ini"), get_theme_path("misc/default/config.ini"), VPath("misc/default/config.ini")};
 
-  for (const VPath &p : backwards_paths) {
+  for (const VPath &p : backwards_paths)
+  {
     QString value = read_design_ini(p_identifier, p);
-    if (!value.isEmpty()) {
+    if (!value.isEmpty())
+    {
       return value.toUtf8();
     }
   }
@@ -325,12 +325,16 @@ QColor AOApplication::get_chat_color(QString p_identifier, QString p_chat)
   QColor return_color(255, 255, 255);
   QString f_result = get_chat_markup(p_identifier, p_chat);
   if (f_result == "")
+  {
     return return_color;
+  }
 
   QStringList color_list = f_result.split(",");
 
   if (color_list.size() < 3)
+  {
     return return_color;
+  }
 
   return_color.setRed(color_list.at(0).toInt());
   return_color.setGreen(color_list.at(1).toInt());
@@ -341,30 +345,33 @@ QColor AOApplication::get_chat_color(QString p_identifier, QString p_chat)
 
 QString AOApplication::get_penalty_value(QString p_identifier)
 {
-  return get_config_value(p_identifier, "penalty/penalty.ini", Options::getInstance().theme(),
-                          Options::getInstance().subTheme(), default_theme, "");
+  return get_config_value(p_identifier, "penalty/penalty.ini", Options::getInstance().theme(), Options::getInstance().subTheme(), default_theme, "");
 }
 
-
 QString AOApplication::get_court_sfx(QString p_identifier, QString p_misc)
 {
   QString value = get_config_value(p_identifier, "courtroom_sounds.ini", Options::getInstance().theme(), Options::getInstance().subTheme(), default_theme, p_misc);
   if (!value.isEmpty())
+  {
     return value.toUtf8();
+  }
   return "";
 }
 
 QString AOApplication::get_sfx_suffix(VPath sound_to_check)
 {
-  QStringList suffixes = {".opus", ".ogg", ".mp3", ".wav", ".mid", ".midi", ".xm", ".it", ".s3m", ".mod", ".mtm", ".umx" };
+  QStringList suffixes = {".opus", ".ogg", ".mp3", ".wav", ".mid", ".midi", ".xm", ".it", ".s3m", ".mod", ".mtm", ".umx"};
   // Check if we were provided a direct filepath with a suffix already
   QString path = sound_to_check.toQString();
   // Loop through our suffixes
-  for (const QString &suffix : suffixes) {
+  for (const QString &suffix : suffixes)
+  {
     // If our VPath ends with a valid suffix
     if (path.endsWith(suffix, Qt::CaseInsensitive))
+    {
       // Return that as the path
       return get_real_path(sound_to_check);
+    }
   }
   // Otherwise, ignore the provided suffix and check our own
   return get_real_path(sound_to_check, suffixes);
@@ -372,20 +379,24 @@ QString AOApplication::get_sfx_suffix(VPath sound_to_check)
 
 QString AOApplication::get_image_suffix(VPath path_to_check, bool static_image)
 {
-  QStringList suffixes {};
-  if (!static_image) {
-    suffixes.append({ ".webp", ".apng", ".gif" });
+  QStringList suffixes{};
+  if (!static_image)
+  {
+    suffixes.append({".webp", ".apng", ".gif"});
   }
   suffixes.append(".png");
 
   // Check if we were provided a direct filepath with a suffix already
   QString path = path_to_check.toQString();
   // Loop through our suffixes
-  for (const QString &suffix : suffixes) {
+  for (const QString &suffix : suffixes)
+  {
     // If our VPath ends with a valid suffix
     if (path.endsWith(suffix, Qt::CaseInsensitive))
+    {
       // Return that as the path
       return get_real_path(path_to_check);
+    }
   }
   // Otherwise, ignore the provided suffix and check our own
   return get_real_path(path_to_check, suffixes);
@@ -394,11 +405,9 @@ QString AOApplication::get_image_suffix(VPath path_to_check, bool static_image)
 // returns whatever is to the right of "search_line =" within target_tag and
 // terminator_tag, trimmed returns the empty string if the search line couldnt
 // be found
-QString AOApplication::read_char_ini(QString p_char, QString p_search_line,
-                                     QString target_tag)
+QString AOApplication::read_char_ini(QString p_char, QString p_search_line, QString target_tag)
 {
-  QSettings settings(get_real_path(get_character_path(p_char, "char.ini")),
-                     QSettings::IniFormat);
+  QSettings settings(get_real_path(get_character_path(p_char, "char.ini")), QSettings::IniFormat);
 #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
   settings.setIniCodec("UTF-8");
 #endif
@@ -408,20 +417,6 @@ QString AOApplication::read_char_ini(QString p_char, QString p_search_line,
   return value;
 }
 
-void AOApplication::set_char_ini(QString p_char, QString value,
-                                 QString p_search_line, QString target_tag)
-{
-  QSettings settings(get_real_path(get_character_path(p_char, "char.ini")),
-                     QSettings::IniFormat);
-
-#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
-  settings.setIniCodec("UTF-8");
-#endif
-  settings.beginGroup(target_tag);
-  settings.setValue(p_search_line, value);
-  settings.endGroup();
-}
-
 // returns all the values of target_tag
 QStringList AOApplication::read_ini_tags(VPath p_path, QString target_tag)
 {
@@ -431,14 +426,19 @@ QStringList AOApplication::read_ini_tags(VPath p_path, QString target_tag)
   settings.setIniCodec("UTF-8");
 #endif
   if (!target_tag.isEmpty())
+  {
     settings.beginGroup(target_tag);
+  }
   QStringList keys = settings.allKeys();
-  foreach (QString key, keys) {
+  foreach (QString key, keys)
+  {
     QString value = settings.value(key).value<QString>();
     r_values << key + "=" + value;
   }
   if (!settings.group().isEmpty())
+  {
     settings.endGroup();
+  }
   return r_values;
 }
 
@@ -448,9 +448,13 @@ QString AOApplication::get_showname(QString p_char)
   QString f_needed = read_char_ini(p_char, "needs_showname", "Options");
 
   if (f_needed.startsWith("false"))
+  {
     return "";
+  }
   if (f_result == "")
+  {
     return p_char;
+  }
   return f_result;
 }
 
@@ -459,7 +463,9 @@ QString AOApplication::get_char_side(QString p_char)
   QString f_result = read_char_ini(p_char, "side", "Options");
 
   if (f_result == "")
+  {
     return "wit";
+  }
   return f_result;
 }
 
@@ -467,42 +473,51 @@ QString AOApplication::get_blips(QString p_char)
 {
   QString f_result = read_char_ini(p_char, "blips", "Options");
 
-  if (f_result == "") {
+  if (f_result == "")
+  {
     f_result = read_char_ini(p_char, "gender", "Options"); // not very PC, FanatSors
     if (f_result == "")
+    {
       f_result = "male";
+    }
   }
 
-  if (!file_exists(get_sfx_suffix(get_sounds_path(f_result)))) {
+  if (!file_exists(get_sfx_suffix(get_sounds_path(f_result))))
+  {
     if (file_exists(get_sfx_suffix(get_sounds_path("../blips/" + f_result))))
+    {
       return "../blips/" + f_result; // Return the cool kids variant
+    }
 
     return "sfx-blip" + f_result; // Return legacy variant
   }
   return f_result;
 }
 
-QString AOApplication::get_emote_property(QString p_char, QString p_emote,
-                                          QString p_property)
+QString AOApplication::get_emote_property(QString p_char, QString p_emote, QString p_property)
 {
-  QString f_result =
-      read_char_ini(p_char, p_emote, p_property); // per-emote override
+  QString f_result = read_char_ini(p_char, p_emote, p_property); // per-emote override
   if (f_result == "")
+  {
     f_result = read_char_ini(p_char, p_property,
                              "Options"); // global for this character
+  }
   return f_result;
 }
 
 Qt::TransformationMode AOApplication::get_misc_scaling(QString p_miscname)
 {
-  if (p_miscname != "") {
-    QString misc_transform_mode = read_design_ini(
-        "scaling", get_theme_path("misc/" + p_miscname + "/config.ini"));
+  if (p_miscname != "")
+  {
+    QString misc_transform_mode = read_design_ini("scaling", get_theme_path("misc/" + p_miscname + "/config.ini"));
     if (misc_transform_mode == "")
-      misc_transform_mode =
-          read_design_ini("scaling", get_misc_path(p_miscname, "config.ini"));
+    {
+      misc_transform_mode = read_design_ini("scaling", get_misc_path(p_miscname, "config.ini"));
+    }
     if (misc_transform_mode == "smooth")
+    {
       return Qt::SmoothTransformation;
+    }
   }
   return Qt::FastTransformation;
 }
@@ -516,7 +531,9 @@ QString AOApplication::get_category(QString p_char)
 QString AOApplication::get_chat(QString p_char)
 {
   if (p_char == "default")
+  {
     return "default";
+  }
   QString f_result = read_char_ini(p_char, "chat", "Options");
   return f_result;
 }
@@ -533,7 +550,9 @@ int AOApplication::get_chat_size(QString p_char)
   QString f_result = read_char_ini(p_char, "chat_size", "Options");
 
   if (f_result == "")
+  {
     return -1;
+  }
   return f_result.toInt();
 }
 
@@ -542,7 +561,9 @@ int AOApplication::get_preanim_duration(QString p_char, QString p_emote)
   QString f_result = read_char_ini(p_char, p_emote, "Time");
 
   if (f_result == "")
+  {
     return -1;
+  }
   return f_result.toInt();
 }
 
@@ -551,18 +572,20 @@ int AOApplication::get_emote_number(QString p_char)
   QString f_result = read_char_ini(p_char, "number", "Emotions");
 
   if (f_result == "")
+  {
     return 0;
+  }
   return f_result.toInt();
 }
 
 QString AOApplication::get_emote_comment(QString p_char, int p_emote)
 {
-  QString f_result =
-      read_char_ini(p_char, QString::number(p_emote + 1), "Emotions");
+  QString f_result = read_char_ini(p_char, QString::number(p_emote + 1), "Emotions");
 
   QStringList result_contents = f_result.split("#");
 
-  if (result_contents.size() < 4) {
+  if (result_contents.size() < 4)
+  {
     qWarning() << "misformatted char.ini: " << p_char << ", " << p_emote;
     return "normal";
   }
@@ -571,12 +594,12 @@ QString AOApplication::get_emote_comment(QString p_char, int p_emote)
 
 QString AOApplication::get_pre_emote(QString p_char, int p_emote)
 {
-  QString f_result =
-      read_char_ini(p_char, QString::number(p_emote + 1), "Emotions");
+  QString f_result = read_char_ini(p_char, QString::number(p_emote + 1), "Emotions");
 
   QStringList result_contents = f_result.split("#");
 
-  if (result_contents.size() < 4) {
+  if (result_contents.size() < 4)
+  {
     qWarning() << "misformatted char.ini: " << p_char << ", " << p_emote;
     return "";
   }
@@ -585,12 +608,12 @@ QString AOApplication::get_pre_emote(QString p_char, int p_emote)
 
 QString AOApplication::get_emote(QString p_char, int p_emote)
 {
-  QString f_result =
-      read_char_ini(p_char, QString::number(p_emote + 1), "Emotions");
+  QString f_result = read_char_ini(p_char, QString::number(p_emote + 1), "Emotions");
 
   QStringList result_contents = f_result.split("#");
 
-  if (result_contents.size() < 4) {
+  if (result_contents.size() < 4)
+  {
     qWarning() << "misformatted char.ini: " << p_char << ", " << p_emote;
     return "normal";
   }
@@ -599,14 +622,13 @@ QString AOApplication::get_emote(QString p_char, int p_emote)
 
 int AOApplication::get_emote_mod(QString p_char, int p_emote)
 {
-  QString f_result =
-      read_char_ini(p_char, QString::number(p_emote + 1), "Emotions");
+  QString f_result = read_char_ini(p_char, QString::number(p_emote + 1), "Emotions");
 
   QStringList result_contents = f_result.split("#");
 
-  if (result_contents.size() < 4) {
-    qWarning() << "misformatted char.ini: " << p_char << ", "
-             << QString::number(p_emote);
+  if (result_contents.size() < 4)
+  {
+    qWarning() << "misformatted char.ini: " << p_char << ", " << QString::number(p_emote);
     return 0;
   }
   return result_contents.at(3).toInt();
@@ -614,89 +636,90 @@ int AOApplication::get_emote_mod(QString p_char, int p_emote)
 
 int AOApplication::get_desk_mod(QString p_char, int p_emote)
 {
-  QString f_result =
-      read_char_ini(p_char, QString::number(p_emote + 1), "Emotions");
+  QString f_result = read_char_ini(p_char, QString::number(p_emote + 1), "Emotions");
 
   QStringList result_contents = f_result.split("#");
 
   if (result_contents.size() < 5)
+  {
     return -1;
+  }
 
   QString string_result = result_contents.at(4);
   if (string_result == "")
+  {
     return -1;
+  }
 
   return string_result.toInt();
 }
 
 QString AOApplication::get_sfx_name(QString p_char, int p_emote)
 {
-  QString f_result =
-      read_char_ini(p_char, QString::number(p_emote + 1), "SoundN");
+  QString f_result = read_char_ini(p_char, QString::number(p_emote + 1), "SoundN");
 
   if (f_result == "")
+  {
     return "1";
-  return f_result;
-}
-
-QString AOApplication::get_emote_blip(QString p_char, int p_emote)
-{
-  QString f_result =
-      read_char_ini(p_char, QString::number(p_emote + 1), "SoundB");
+  }
   return f_result;
 }
 
 int AOApplication::get_sfx_delay(QString p_char, int p_emote)
 {
-  QString f_result =
-      read_char_ini(p_char, QString::number(p_emote + 1), "SoundT");
+  QString f_result = read_char_ini(p_char, QString::number(p_emote + 1), "SoundT");
 
   if (f_result == "")
+  {
     return 1;
+  }
   return f_result.toInt();
 }
 
 QString AOApplication::get_sfx_looping(QString p_char, int p_emote)
 {
-  QString f_result =
-      read_char_ini(p_char, QString::number(p_emote + 1), "SoundL");
+  QString f_result = read_char_ini(p_char, QString::number(p_emote + 1), "SoundL");
 
   if (f_result == "")
+  {
     return "0";
+  }
   else
+  {
     return f_result;
+  }
 }
 
-QString AOApplication::get_sfx_frame(QString p_char, QString p_emote,
-                                     int n_frame)
+QString AOApplication::get_sfx_frame(QString p_char, QString p_emote, int n_frame)
 {
-  QString f_result = read_char_ini(p_char, QString::number(n_frame),
-                                   p_emote.append("_FrameSFX"));
+  QString f_result = read_char_ini(p_char, QString::number(n_frame), p_emote.append("_FrameSFX"));
 
   if (f_result == "")
+  {
     return "";
+  }
   return f_result;
 }
 
-QString AOApplication::get_screenshake_frame(QString p_char, QString p_emote,
-                                             int n_frame)
+QString AOApplication::get_screenshake_frame(QString p_char, QString p_emote, int n_frame)
 {
-  QString f_result = read_char_ini(p_char, QString::number(n_frame),
-                                   p_emote.append("_FrameScreenshake"));
+  QString f_result = read_char_ini(p_char, QString::number(n_frame), p_emote.append("_FrameScreenshake"));
 
   if (f_result == "")
+  {
     return "";
+  }
   return f_result;
 }
 
-QString AOApplication::get_flash_frame(QString p_char, QString p_emote,
-                                       int n_frame)
+QString AOApplication::get_flash_frame(QString p_char, QString p_emote, int n_frame)
 {
-  QString f_result = read_char_ini(p_char, QString::number(n_frame),
-                                   p_emote.append("_FrameRealization"));
+  QString f_result = read_char_ini(p_char, QString::number(n_frame), p_emote.append("_FrameRealization"));
 
   if (f_result == "")
+  {
     return "";
+  }
   return f_result;
 }
 
@@ -705,15 +728,17 @@ int AOApplication::get_text_delay(QString p_char, QString p_emote)
   QString f_result = read_char_ini(p_char, p_emote, "stay_time");
 
   if (f_result == "")
+  {
     return -1;
+  }
   return f_result.toInt();
 }
 
 QStringList AOApplication::get_effects(QString p_char)
 {
   const QStringList l_filepath_list{
-    get_asset("effects/effects.ini", Options::getInstance().theme(), Options::getInstance().subTheme(), default_theme, ""),
-    get_asset("effects.ini", Options::getInstance().theme(), Options::getInstance().subTheme(), default_theme, read_char_ini(p_char, "effects", "Options")),
+      get_asset("effects/effects.ini", Options::getInstance().theme(), Options::getInstance().subTheme(), default_theme, ""),
+      get_asset("effects.ini", Options::getInstance().theme(), Options::getInstance().subTheme(), default_theme, read_char_ini(p_char, "effects", "Options")),
   };
 
   QStringList l_effect_name_list;
@@ -728,14 +753,16 @@ QStringList AOApplication::get_effects(QString p_char)
 #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
     l_effects_ini.setIniCodec("UTF-8");
 #endif
-         // port legacy effects
+    // port legacy effects
     if (!l_effects_ini.contains("version/major") || l_effects_ini.value("version/major").toInt() < 2)
     {
       QFile effects_old(i_filepath);
-      if (QFile::copy(i_filepath, i_filepath + ".old")) {
+      if (QFile::copy(i_filepath, i_filepath + ".old"))
+      {
         AOUtils::migrateEffects(l_effects_ini);
       }
-      else {
+      else
+      {
         qWarning() << "Unable to copy effects.ini, skipping migration.";
       }
     }
@@ -751,9 +778,7 @@ QStringList AOApplication::get_effects(QString p_char)
       }
     }
 
-    std::sort(l_group_list.begin(), l_group_list.end(), [](const QString &lhs, const QString &rhs) {
-      return lhs.toInt() < rhs.toInt();
-    });
+    std::sort(l_group_list.begin(), l_group_list.end(), [](const QString &lhs, const QString &rhs) { return lhs.toInt() < rhs.toInt(); });
 
     for (const QString &i_group : qAsConst(l_group_list))
     {
@@ -775,46 +800,54 @@ QStringList AOApplication::get_effects(QString p_char)
   return l_effect_name_list;
 }
 
-QString AOApplication::get_effect(QString effect, QString p_char,
-                                  QString p_folder)
+QString AOApplication::get_effect(QString effect, QString p_char, QString p_folder)
 {
   if (p_folder == "")
+  {
     p_folder = read_char_ini(p_char, "effects", "Options");
+  }
 
-  QStringList paths {
-    get_image("effects/" + effect, Options::getInstance().theme(), Options::getInstance().subTheme(), default_theme, ""),
-    get_image(effect, Options::getInstance().theme(), Options::getInstance().subTheme(), default_theme, p_folder)
-  };
+  QStringList paths{get_image("effects/" + effect, Options::getInstance().theme(), Options::getInstance().subTheme(), default_theme, ""), get_image(effect, Options::getInstance().theme(), Options::getInstance().subTheme(), default_theme, p_folder)};
 
   for (const auto &p : paths)
+  {
     if (file_exists(p))
+    {
       return p;
+    }
+  }
   return {};
 }
 
-QString AOApplication::get_effect_property(QString fx_name, QString p_char,
-                                           QString p_folder, QString p_property)
+QString AOApplication::get_effect_property(QString fx_name, QString p_char, QString p_folder, QString p_property)
 {
   if (p_folder == "")
+  {
     p_folder = read_char_ini(p_char, "effects", "Options");
+  }
 
   const auto paths = get_asset_paths("effects/effects.ini", Options::getInstance().theme(), Options::getInstance().subTheme(), default_theme, "");
   const auto misc_paths = get_asset_paths("effects.ini", Options::getInstance().theme(), Options::getInstance().subTheme(), default_theme, p_folder);
   QString path;
   QString f_result;
-  for (const VPath &p : paths + misc_paths) {
+  for (const VPath &p : paths + misc_paths)
+  {
     path = get_real_path(p);
-    if (!path.isEmpty()) {
+    if (!path.isEmpty())
+    {
       QSettings settings(path, QSettings::IniFormat);
 #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
       settings.setIniCodec("UTF-8");
 #endif
       QStringList char_effects = settings.childGroups();
-      for (int i = 0; i < char_effects.size(); ++i) {
+      for (int i = 0; i < char_effects.size(); ++i)
+      {
         QString effect = settings.value(char_effects[i] + "/name").toString();
-        if (effect.toLower() == fx_name.toLower()) {
+        if (effect.toLower() == fx_name.toLower())
+        {
           f_result = settings.value(char_effects[i] + "/" + p_property).toString();
-          if (!f_result.isEmpty()) {
+          if (!f_result.isEmpty())
+          {
             // Only break the loop if we get a non-empty result, continue the search otherwise
             break;
           }
@@ -822,7 +855,8 @@ QString AOApplication::get_effect_property(QString fx_name, QString p_char,
       }
     }
   }
-  if (fx_name == "realization" && p_property == "sound") {
+  if (fx_name == "realization" && p_property == "sound")
+  {
     f_result = get_custom_realization(p_char);
   }
   return f_result;
@@ -832,15 +866,18 @@ QString AOApplication::get_custom_realization(QString p_char)
 {
   QString f_result = read_char_ini(p_char, "realization", "Options");
   if (f_result == "")
+  {
     return get_court_sfx("realization");
+  }
   return get_sfx_suffix(get_sounds_path(f_result));
 }
 
 bool AOApplication::get_pos_is_judge(const QString &p_pos)
 {
   QStringList positions = read_design_ini("judges", get_background_path("design.ini")).split(",");
-  if (positions.size() == 1 && positions[0] == "") {
-      return p_pos == "jud"; //Hardcoded BS only if we have no judges= defined
+  if (positions.size() == 1 && positions[0] == "")
+  {
+    return p_pos == "jud"; // Hardcoded BS only if we have no judges= defined
   }
   return positions.contains(p_pos.trimmed());
 }