2.10.1 Changes (#888)

* Utilise .ui file to create settings dialog (#858)

* Remove config loading from AOApplications

Removes most, but not all config functions from AOApplication and moves them into their own class.

Not even remotely done here. but holy shit I'm tired.

* First steps towards UI file

* Fixed your UI layout issue

* Leifa bullies me

* Set all the setters

Reminder : Figure out why username and ooc_name exist. Are they the same? Maybe. Maybe not. Gonna have to look at it and migrate the key.

Todo : Cleanup key naming. Most of these are terrible, imprecise or I just don't like them.

* Make layout appear proper

* Minor option dialog update

* Hookup AOOptionsdialogue to Options Getter/setter

Not done yet, but parts of the options interactions work again.

* More settings menu working

* Mostly working settings dialogue

Restore default and cancel still need work

* Fix asset widget

* Tooltips

Also removes the commented out tooltip code

* Finish Tooltips

Move widget implementation to its own folder

* Migrate callwords to config.ini

Also correct sleep deprived code.

* Fix widget translation

* Language dropdown changes

We might want to look into doing this a bit better.

* Remove QSettings from AOApplication

Try cleaning up stray references to said object anymore

* Fix constructor order to prevent runtime crash

* Slightly sort implementation file

* Remove unused label declarations from header

Fix some comments

* Formatting

* Fix buttons

Also fixes restore settings when a restore to default is aborted.

* Raise pair list after courtroom construction (#859)

* Don't reset evidence selection (#860)

They are defaulted in the header. This SHOULD not affect the client negatively.

* Hitting the emergency exit (#861)

Don't change the widget state when the ID exceeds the current widget list due to pages being changed while evidence is being edited.

* add CI and license badge

* add contributors

* Handle config.temp after confirmation

* Deletes config.temp when the user has confirmed they want to keep the current settings.

* Make reset to default destructive

Don't worry, we ask first! :)

* Fix case of self_offset received without a y offset (#864)

caused by typos in #701

it's possible for older clients to send x offsets without a y
offset. if you think this case is annoying you can remove it in
the next version and handle it server-side instead

* Change default settings (#839)

* Make default config enable features for most cases except for Continuous Playback due to it introducing performance issues according to tooltip and confirmed in testing
* Increase log size to 1000
* Default disable animated themes

Co-authored-by: Salanto <62221668+Salanto@users.noreply.github.com>
Co-authored-by: stonedDiscord <Tukz@gmx.de>

* Make it a singleton? Maybe? I dunno? Ask Longbyte

* Commit suggestions

* More suggestions

Also try fixing a memory leak. Not going to well.

* Return to dialog

Otherwise we don't have Exec.

* Cleanup

* Deprecate ooc_name, implement username

* Remove ooc_name key and copy its value to default_showname if its empty.

* Consistent naming in AOOptionsDialog

* Clang format

* Don't write the username to the showname

* Fix theme dropdown being incorrectly set

* Bandaid callword playing every message

* Remove unused or duplicate includes

* More include removals

Removes lobby and courtroom direct includes from the dialog source

* Burn baby, burn!

* Remove reload_theme function

* Remove "Case Alert Supported Message"

All servers I tested on master supported it. The text is redundant in operation.

Co-authored-by: TrickyLeifa <date.epoch@gmail.com>
Co-authored-by: stonedDiscord <Tukz@gmx.de>
Co-authored-by: oldmud0 <oldmud0@users.noreply.github.com>
Co-authored-by: Crystalwarrior <Varsash@Gmail.com>

* Cleanup lobby (#880)

* Remove config loading from AOApplications

Removes most, but not all config functions from AOApplication and moves them into their own class.

Not even remotely done here. but holy shit I'm tired.

* First steps towards UI file

* Fixed your UI layout issue

* Leifa bullies me

* Set all the setters

Reminder : Figure out why username and ooc_name exist. Are they the same? Maybe. Maybe not. Gonna have to look at it and migrate the key.

Todo : Cleanup key naming. Most of these are terrible, imprecise or I just don't like them.

* Make layout appear proper

* Minor option dialog update

* Hookup AOOptionsdialogue to Options Getter/setter

Not done yet, but parts of the options interactions work again.

* More settings menu working

* Mostly working settings dialogue

Restore default and cancel still need work

* Fix asset widget

* Tooltips

Also removes the commented out tooltip code

* Finish Tooltips

Move widget implementation to its own folder

* Migrate callwords to config.ini

Also correct sleep deprived code.

* Fix widget translation

* Language dropdown changes

We might want to look into doing this a bit better.

* Remove QSettings from AOApplication

Try cleaning up stray references to said object anymore

* Fix constructor order to prevent runtime crash

* Slightly sort implementation file

* Remove unused label declarations from header

Fix some comments

* Formatting

* Fix buttons

Also fixes restore settings when a restore to default is aborted.

* Raise pair list after courtroom construction (#859)

* Don't reset evidence selection (#860)

They are defaulted in the header. This SHOULD not affect the client negatively.

* Hitting the emergency exit (#861)

Don't change the widget state when the ID exceeds the current widget list due to pages being changed while evidence is being edited.

* add CI and license badge

* add contributors

* Handle config.temp after confirmation

* Deletes config.temp when the user has confirmed they want to keep the current settings.

* Make reset to default destructive

Don't worry, we ask first! :)

* Fix case of self_offset received without a y offset (#864)

caused by typos in #701

it's possible for older clients to send x offsets without a y
offset. if you think this case is annoying you can remove it in
the next version and handle it server-side instead

* Change default settings (#839)

* Make default config enable features for most cases except for Continuous Playback due to it introducing performance issues according to tooltip and confirmed in testing
* Increase log size to 1000
* Default disable animated themes


Co-authored-by: Salanto <62221668+Salanto@users.noreply.github.com>
Co-authored-by: stonedDiscord <Tukz@gmx.de>

* Make it a singleton? Maybe? I dunno? Ask Longbyte

* Commit suggestions

* More suggestions

Also try fixing a memory leak. Not going to well.

* Return to dialog

Otherwise we don't have Exec.

* Cleanup

* Deprecate ooc_name, implement username

* Remove ooc_name key and copy its value to default_showname if its empty.

* Consistent naming in AOOptionsDialog

* Clang format

* Don't write the username to the showname

* Fix theme dropdown being incorrectly set

* Bandaid callword playing every message

* Remove unused or duplicate includes

* More include removals

Removes lobby and courtroom direct includes from the dialog source

* Burn baby, burn!

* Remove reload_theme function

* Remove "Case Alert Supported Message"

All servers I tested on master supported it. The text is redundant in operation.

* Create preliminary lobby design

Attempts to slightly modernize the aging lobby to a scheme more akin to modern server browsers.

* Fix missing header, add necessary search lineedits

* More UI changes

* Start hooking up new UI elements

* Hookup Serverbrowser to new UI frontend

Still need to fix the favorites AND implement the NEW demolist

* Fixup demo ui and make demoserver functional

* More demoserver cleanup

* Remove jarring ao_app pointer shenigans

Still a bit to do before we can safely remove that pointer, but hey, its something.

* *unholy screeches*

Tried to untangle the tange of dependencies that is connection behaviour

* Rip out loading screen

Some servers are not even sending proper values anymore, like vanilla, so why keep it?

* Optimise includes, format header

Lobby should not even have to know what an AOPacket is, smh

* Formatting fixes

and turn settings menu opening into a signal

* Why does netmanager never emit when the server is connected

* Fixup final parts

About as well implemented as I can do rn. Missing the load screen, but that was more flair than anything else

* Correct start page

* demo qol

Co-authored-by: TrickyLeifa <date.epoch@gmail.com>
Co-authored-by: stonedDiscord <Tukz@gmx.de>
Co-authored-by: oldmud0 <oldmud0@users.noreply.github.com>
Co-authored-by: Crystalwarrior <Varsash@Gmail.com>

* Delete rebase artifact

* only set setting codec on qt5

* fix old regex

* qlocale include was missing

* Add default soundfont value + cleaup stream checks

* Remove Case Announcement

* Add add_server dialog and move logic to options.h

* Add Direction Connection Widget and function

* Visual Fluff, don't show direct connection on demo screen

* Implement ui-file reload and RCC mounting.

* Add edit menu to favorites

* Add Server remains active when no server is selected

* Hack together window title for courtroom

I hate this.

* Fix incorrect subtheme location code

* Cleanup

* Make all charicons appear on first join

This entire system needs a rework, but this will do for now.

Also slightly improves performance by not making it load the character list 4 times, only 2 now :^)
closes #854

* Fix evidence hover selector under Qt5

#closes #890

* Remove options calling itself trough pointer

* Fix Android CI (#891)

* pro gamer move

* remove pregenerated android files

* version

* install old ass android platform

* Revert "remove pregenerated android files"

This reverts commit c81a94c6fd337e187af61e9dd706fac5cd51bcc0.

* switch to 24

* CharButton - Fix enterEvent override in Qt5

Also mark them as override. Also make the preprocessor if a bit less copypastey.

* version bump

* Update embeeded lobby ui color sheme

Shoutout to Dumb Fuck (That is their real discord name).

Co-Authored-By: Crystalwarrior <3470436+Crystalwarrior@users.noreply.github.com>

* Add changelog.md loading logic from main mount path

* Expand tabbar of optional Tabbar widget

* Fix order column being incorrectly sized

* missed a space

* remove fonts

* change margins

* fix minimum sizes

* Allow theme overwrite of settings menu

* Cleanup iterator for subthemes

* Allow reload of settings menu

Might aswell do them all :shrug:

* AO base path (#893)

* make get_base_path global

and move parts that use base to use it

* options uses base

* sal moved a bunch of code

* fix creating case folder

---------

Co-authored-by: stonedDiscord <10584181+stonedDiscord@users.noreply.github.com>

* Android 2 10 1 (#894)

* ask for file permissions before trying to load a file

* create armv7 gitignore

* extract all the abis

* don't fail if the dir exists

* Clear options map before reloading the UI

* Fix runtime warning for theme/subtheme combobox

Shouldn't do the job of something that the template can do for me.
Also fix formatting cause it was busted.
Also made the subtheme/theme load code not give me cancer.

* Sort dropdown numerically to match explorer preview

closes #793

* fuck bass

* copy mingw

* copy other dll

* wrong folder

* Account for server subtheme

* Replace incorrect subtheme check

* Settings, not server

* Remove debug

* Add compatibility code, suppress compiler warning (#896)

lobby.cpp:
* Added compatibility code so 2.10.1 can run on Qt versions older than 5.14, such as the version that ships with Ubuntu 20.04

courtroom.cpp:
* Used a Q_UNUSED macro on an unused variable to suppress a compiler warning

* Resolve Qt6(.5.0) compiler errors

* Undo incompetence.

* Force theme reload on theme change

If a user saves a new theme and does not reload the UI it will cause misplacement of widgets inside of courtroom.
This is mitigated by forcing a reload.

* make speedlines stretch by default (in *actually* non-stupid way this time) (#901)

* Rework default volume settings (#903)

* rework volume default settings

* remove default volume settings in options dialog
* make client remember last volume settings instead

* fix options starting tab

* Reworked direct connect (#906)

Resolve issue #905
Works as advertised.

* Set join text when double-click on connected server

Good enough. I would handle this a bit smarter and lock based on the connection state of NetworkManager, but NetworkManager sucks and I refuse to fix it this close before 2.10.1 is done.

* remove unused m_looping

* remove useless underflow check

* do not fall from server to favorites

* Ci android fix (#899)

* pro gamer move

* remove pregenerated android files

* version

* install old ass android platform

* Revert "remove pregenerated android files"

This reverts commit c81a94c6fd337e187af61e9dd706fac5cd51bcc0.

* switch to 24

* use android\src\android\templates instead

* deprecate "chat" deskmod (#910)

* ignore deskmod when zoom speaking

* clean up deskmod a bit

* adds an enum for deskmods
* deprecates the "chat" deskmood
* modifies set_scene since it never rly used the deskmod argument
  meaningfully

* actually use the enums i made lol

* fix typo

* Add credits for lamdacalculus

---------

Co-authored-by: TrickyLeifa <date.epoch@gmail.com>
Co-authored-by: stonedDiscord <Tukz@gmx.de>
Co-authored-by: oldmud0 <oldmud0@users.noreply.github.com>
Co-authored-by: Crystalwarrior <Varsash@Gmail.com>
Co-authored-by: Crystalwarrior <3470436+Crystalwarrior@users.noreply.github.com>
Co-authored-by: stonedDiscord <10584181+stonedDiscord@users.noreply.github.com>
Co-authored-by: segfault <128277930+memsecviolator@users.noreply.github.com>
Co-authored-by: lambdcalculus <64238778+lambdcalculus@users.noreply.github.com>
Co-authored-by: Leifa♥ <26681464+TrickyLeifa@users.noreply.github.com>

1 files changed, 648 insertions, 0 deletions

diff --git a/src/widgets/aooptionsdialog.cpp b/src/widgets/aooptionsdialog.cpp
new file mode 100644
index 00000000..8b7befe9
--- /dev/null
+++ b/src/widgets/aooptionsdialog.cpp
@@ -0,0 +1,648 @@
+#include "widgets/aooptionsdialog.h"
+#include "QDesktopServices"
+#include "aoapplication.h"
+#include "bass.h"
+#include "file_functions.h"
+#include "networkmanager.h"
+#include "options.h"
+
+#include <QCheckBox>
+#include <QCollator>
+#include <QComboBox>
+#include <QDialogButtonBox>
+#include <QGroupBox>
+#include <QLabel>
+#include <QLineEdit>
+#include <QPlainTextEdit>
+#include <QPushButton>
+#include <QResource>
+#include <QSpinBox>
+#include <QUiLoader>
+#include <QVBoxLayout>
+
+#define FROM_UI(type, name)                                                    \
+  ;                                                                            \
+  ui_##name = findChild<type *>(#name);
+
+AOOptionsDialog::AOOptionsDialog(QDialog *parent, AOApplication *p_ao_app)
+    : QDialog(parent)
+{
+  ao_app = p_ao_app;
+  setupUI();
+}
+
+void AOOptionsDialog::populateAudioDevices()
+{
+  ui_audio_device_combobox->clear();
+  if (needsDefaultAudioDevice()) {
+    ui_audio_device_combobox->addItem("default");
+  }
+
+  BASS_DEVICEINFO info;
+  for (int a = 0; BASS_GetDeviceInfo(a, &info); a++) {
+    ui_audio_device_combobox->addItem(info.name);
+  }
+}
+
+template <>
+void AOOptionsDialog::setWidgetData(QCheckBox *widget, const bool &value)
+{
+  widget->setChecked(value);
+}
+
+template <> bool AOOptionsDialog::widgetData(QCheckBox *widget) const
+{
+  return widget->isChecked();
+}
+
+template <>
+void AOOptionsDialog::setWidgetData(QLineEdit *widget, const QString &value)
+{
+  widget->setText(value);
+}
+
+template <> QString AOOptionsDialog::widgetData(QLineEdit *widget) const
+{
+  return widget->text();
+}
+
+template <>
+void AOOptionsDialog::setWidgetData(QLineEdit *widget, const uint16_t &value)
+{
+  widget->setText(QString::number(value));
+}
+
+template <> uint16_t AOOptionsDialog::widgetData(QLineEdit *widget) const
+{
+  return widget->text().toUShort();
+}
+
+template <>
+void AOOptionsDialog::setWidgetData(QPlainTextEdit *widget,
+                                    const QStringList &value)
+{
+  widget->setPlainText(value.join('\n'));
+}
+
+template <>
+QStringList AOOptionsDialog::widgetData(QPlainTextEdit *widget) const
+{
+  return widget->toPlainText().trimmed().split('\n');
+}
+
+template <>
+void AOOptionsDialog::setWidgetData(QSpinBox *widget, const int &value)
+{
+  widget->setValue(value);
+}
+
+template <> int AOOptionsDialog::widgetData(QSpinBox *widget) const
+{
+  return widget->value();
+}
+
+template <>
+void AOOptionsDialog::setWidgetData(QComboBox *widget, const QString &value)
+{
+  for (auto i = 0; i < widget->count(); i++) {
+    if (widget->itemText(i) == value) {
+      widget->setCurrentIndex(i);
+      return;
+    }
+  }
+  qWarning() << "value" << value << "not found for widget"
+             << widget->objectName();
+}
+
+template <> QString AOOptionsDialog::widgetData(QComboBox *widget) const
+{
+  return widget->currentText();
+}
+
+template <>
+void AOOptionsDialog::setWidgetData(QGroupBox *widget, const bool &value)
+{
+  widget->setChecked(value);
+}
+
+template <> bool AOOptionsDialog::widgetData(QGroupBox *widget) const
+{
+  return widget->isChecked();
+}
+
+template <>
+void AOOptionsDialog::setWidgetData(QListWidget *widget,
+                                    const QStringList &value)
+{
+  widget->addItems(value);
+}
+
+template <> QStringList AOOptionsDialog::widgetData(QListWidget *widget) const
+{
+  QStringList paths;
+  for (auto i = 1; i < widget->count(); i++) {
+    paths.append(widget->item(i)->text());
+  }
+  return paths;
+}
+
+template <typename T, typename V>
+void AOOptionsDialog::registerOption(const QString &widgetName,
+                                     V (Options::*getter)() const,
+                                     void (Options::*setter)(V))
+{
+  auto *widget = findChild<T *>(widgetName);
+  if (!widget) {
+    qWarning() << "could not find widget" << widgetName;
+    return;
+  }
+
+  OptionEntry entry;
+  entry.load = [=] {
+    setWidgetData<T, V>(widget, (Options::getInstance().*getter)());
+  };
+  entry.save = [=] {
+    (Options::getInstance().*setter)(widgetData<T, V>(widget));
+  };
+
+  optionEntries.append(entry);
+}
+
+void AOOptionsDialog::updateValues()
+{
+  QSet<QString> themes;
+  QStringList bases = Options::getInstance().mountPaths();
+  bases.push_front(get_base_path());
+
+  for (const QString &base : bases) {
+    QStringList l_themes =
+        QDir(base + "themes").entryList(QDir::Dirs | QDir::NoDotAndDotDot);
+
+    // Resorts list to match numeric sorting found in Windows.
+    QCollator l_sorting;
+    l_sorting.setNumericMode(true);
+    std::sort(l_themes.begin(), l_themes.end(), l_sorting);
+
+    for (const QString &l_theme : qAsConst(l_themes)) {
+      if (!themes.contains(l_theme)) {
+        ui_theme_combobox->addItem(l_theme);
+        themes.insert(l_theme);
+      }
+    }
+  }
+
+  QStringList l_subthemes =
+      QDir(ao_app->get_real_path(ao_app->get_theme_path("")))
+          .entryList(QDir::Dirs | QDir::NoDotAndDotDot);
+  for (const QString &l_subtheme : qAsConst(l_subthemes)) {
+    if (l_subtheme.toLower() != "server" && l_subtheme.toLower() != "default" &&
+        l_subtheme.toLower() != "effects" && l_subtheme.toLower() != "misc") {
+      ui_subtheme_combobox->addItem(l_subtheme);
+    }
+  }
+
+  ao_app->net_manager->request_document(
+      MSDocumentType::PrivacyPolicy, [this](QString document) {
+        if (document.isEmpty()) {
+          document = tr("Couldn't get the privacy policy.");
+        }
+        ui_privacy_policy->setHtml(document);
+      });
+
+  for (const OptionEntry &entry : qAsConst(optionEntries)) {
+    entry.load();
+  }
+}
+
+void AOOptionsDialog::savePressed()
+{
+  bool l_reload_theme_required = (ui_theme_combobox->currentText() != Options::getInstance().theme());
+  for (const OptionEntry &entry : qAsConst(optionEntries)) {
+    entry.save();
+  }
+
+  if (l_reload_theme_required) {
+    emit reloadThemeRequest();
+  }
+  close();
+}
+
+void AOOptionsDialog::discardPressed() { close(); }
+
+void AOOptionsDialog::buttonClicked(QAbstractButton *button)
+{
+  if (ui_settings_buttons->buttonRole(button) == QDialogButtonBox::ResetRole) {
+    if (QMessageBox::question(
+            this, "", "Restore default settings?\nThis can't be undone!",
+            QMessageBox::Yes | QMessageBox::No) == QMessageBox::Yes) {
+      // Destructive operation.
+      Options::getInstance().clearConfig();
+      updateValues();
+    }
+  }
+}
+
+void AOOptionsDialog::onReloadThemeClicked()
+{
+  Options::getInstance().setTheme(ui_theme_combobox->currentText());
+  Options::getInstance().setSettingsSubTheme(ui_subtheme_combobox->currentText());
+  Options::getInstance().setAnimatedThemeEnabled(
+      ui_animated_theme_cb->isChecked());
+  emit reloadThemeRequest();
+  delete layout();
+  delete ui_settings_widget;
+  optionEntries.clear();
+  setupUI();
+}
+
+void AOOptionsDialog::themeChanged(int i)
+{
+  ui_subtheme_combobox->clear();
+  // Fill the combobox with the names of the themes.
+  ui_subtheme_combobox->addItem("server");
+  ui_subtheme_combobox->addItem("default");
+
+  QStringList l_subthemes = QDir(ao_app->get_real_path(ao_app->get_theme_path(
+                                     "", ui_theme_combobox->itemText(i))))
+                                .entryList(QDir::Dirs | QDir::NoDotAndDotDot);
+
+  for (const QString &l_subthemes : qAsConst(l_subthemes)) {
+    if (l_subthemes.toLower() != "server" &&
+        l_subthemes.toLower() != "default" &&
+        l_subthemes.toLower() != "effects" && l_subthemes.toLower() != "misc") {
+      ui_subtheme_combobox->addItem(l_subthemes);
+    }
+  }
+
+  QString l_ressource_name = Options::getInstance().theme() + ".rcc";
+  QString l_resource =
+      ao_app->get_asset("themes/" + ui_theme_combobox->currentText() + ".rcc");
+  if (l_resource.isEmpty()) {
+    QResource::unregisterResource(
+        ao_app->get_asset("themes/" + l_ressource_name));
+    qDebug() << "Unable to locate ressource file" << l_ressource_name;
+    return;
+  }
+  QResource::registerResource(l_resource);
+}
+
+void AOOptionsDialog::setupUI()
+{
+  QUiLoader l_loader(this);
+  QFile l_uiFile(Options::getInstance().getUIAsset("options_dialog.ui"));
+  if (!l_uiFile.open(QFile::ReadOnly)) {
+    qWarning() << "Unable to open file " << l_uiFile.fileName();
+    return;
+  }
+
+  ui_settings_widget = l_loader.load(&l_uiFile, this);
+
+  auto l_layout = new QVBoxLayout(this);
+  l_layout->addWidget(ui_settings_widget);
+
+  // General dialog element.
+  FROM_UI(QDialogButtonBox, settings_buttons);
+
+  connect(ui_settings_buttons, &QDialogButtonBox::accepted, this,
+          &AOOptionsDialog::savePressed);
+  connect(ui_settings_buttons, &QDialogButtonBox::rejected, this,
+          &AOOptionsDialog::discardPressed);
+  connect(ui_settings_buttons, &QDialogButtonBox::clicked, this,
+          &AOOptionsDialog::buttonClicked);
+
+  // Gameplay Tab
+  FROM_UI(QComboBox, theme_combobox)
+  connect(ui_theme_combobox,
+          QOverload<int>::of(&QComboBox::currentIndexChanged), this,
+          &AOOptionsDialog::themeChanged);
+
+  registerOption<QComboBox, QString>("theme_combobox", &Options::theme,
+                                     &Options::setTheme);
+
+  FROM_UI(QComboBox, subtheme_combobox)
+  registerOption<QComboBox, QString>("subtheme_combobox", &Options::settingsSubTheme,
+                                     &Options::setSettingsSubTheme);
+
+  FROM_UI(QPushButton, theme_reload_button)
+  connect(ui_theme_reload_button, &QPushButton::clicked, this,
+          &::AOOptionsDialog::onReloadThemeClicked);
+
+  FROM_UI(QPushButton, theme_folder_button)
+  connect(ui_theme_folder_button, &QPushButton::clicked, this, [=] {
+    QString p_path = ao_app->get_real_path(ao_app->get_theme_path(
+        "", ui_theme_combobox->itemText(ui_theme_combobox->currentIndex())));
+    if (!dir_exists(p_path)) {
+      return;
+    }
+    QDesktopServices::openUrl(QUrl::fromLocalFile(p_path));
+  });
+
+  FROM_UI(QCheckBox, animated_theme_cb)
+  FROM_UI(QSpinBox, stay_time_spinbox)
+  FROM_UI(QCheckBox, instant_objection_cb)
+  FROM_UI(QSpinBox, text_crawl_spinbox)
+  FROM_UI(QSpinBox, chat_ratelimit_spinbox)
+  FROM_UI(QLineEdit, username_textbox)
+  FROM_UI(QCheckBox, showname_cb)
+  FROM_UI(QLineEdit, default_showname_textbox)
+  FROM_UI(QLineEdit, ms_textbox)
+  FROM_UI(QCheckBox, discord_cb)
+  FROM_UI(QComboBox, language_combobox)
+  FROM_UI(QComboBox, scaling_combobox)
+  FROM_UI(QCheckBox, shake_cb)
+  FROM_UI(QCheckBox, effects_cb)
+  FROM_UI(QCheckBox, framenetwork_cb)
+  FROM_UI(QCheckBox, colorlog_cb)
+  FROM_UI(QCheckBox, stickysounds_cb)
+  FROM_UI(QCheckBox, stickyeffects_cb)
+  FROM_UI(QCheckBox, stickypres_cb)
+  FROM_UI(QCheckBox, customchat_cb)
+  FROM_UI(QCheckBox, sticker_cb)
+  FROM_UI(QCheckBox, continuous_cb)
+  FROM_UI(QCheckBox, category_stop_cb)
+  FROM_UI(QCheckBox, sfx_on_idle_cb)
+  FROM_UI(QCheckBox, evidence_double_click_cb)
+
+  registerOption<QCheckBox, bool>("animated_theme_cb",
+                                  &Options::animatedThemeEnabled,
+                                  &Options::setAnimatedThemeEnabled);
+  registerOption<QSpinBox, int>("stay_time_spinbox", &Options::textStayTime,
+                                &Options::setTextStayTime);
+  registerOption<QCheckBox, bool>("instant_objection_cb",
+                                  &Options::objectionSkipQueueEnabled,
+                                  &Options::setObjectionSkipQueueEnabled);
+  registerOption<QSpinBox, int>("text_crawl_spinbox", &Options::textCrawlSpeed,
+                                &Options::setTextCrawlSpeed);
+  registerOption<QSpinBox, int>("chat_ratelimit_spinbox",
+                                &Options::chatRateLimit,
+                                &Options::setChatRateLimit);
+  registerOption<QLineEdit, QString>("username_textbox", &Options::username,
+                                     &Options::setUsername);
+  registerOption<QCheckBox, bool>("showname_cb",
+                                  &Options::customShownameEnabled,
+                                  &Options::setCustomShownameEnabled);
+  registerOption<QLineEdit, QString>("default_showname_textbox",
+                                     &Options::shownameOnJoin,
+                                     &Options::setShownameOnJoin);
+  registerOption<QLineEdit, QString>("ms_textbox",
+                                     &Options::alternativeMasterserver,
+                                     &Options::setAlternativeMasterserver);
+  registerOption<QCheckBox, bool>("discord_cb", &Options::discordEnabled,
+                                  &Options::setDiscordEnabled);
+  registerOption<QComboBox, QString>("language_combobox", &Options::language,
+                                     &Options::setLanguage);
+  registerOption<QComboBox, QString>("scaling_combobox",
+                                     &Options::defaultScalingMode,
+                                     &Options::setDefaultScalingMode);
+
+  // Populate scaling dropdown. This is necessary as we need the user data
+  // embeeded into the entry.
+  ui_scaling_combobox->addItem(tr("Pixel"), "fast");
+  ui_scaling_combobox->addItem(tr("Smooth"), "smooth");
+
+  registerOption<QCheckBox, bool>("shake_cb", &Options::shakeEnabled,
+                                  &Options::setShakeEnabled);
+  registerOption<QCheckBox, bool>("effects_cb", &Options::effectsEnabled,
+                                  &Options::setEffectsEnabled);
+  registerOption<QCheckBox, bool>("framenetwork_cb",
+                                  &Options::networkedFrameSfxEnabled,
+                                  &Options::setNetworkedFrameSfxEnabled);
+  registerOption<QCheckBox, bool>("colorlog_cb", &Options::colorLogEnabled,
+                                  &Options::setColorLogEnabled);
+  registerOption<QCheckBox, bool>(
+      "stickysounds_cb", &Options::clearSoundsDropdownOnPlayEnabled,
+      &Options::setClearSoundsDropdownOnPlayEnabled);
+  registerOption<QCheckBox, bool>(
+      "stickyeffects_cb", &Options::clearEffectsDropdownOnPlayEnabled,
+      &Options::setClearEffectsDropdownOnPlayEnabled);
+  registerOption<QCheckBox, bool>("stickypres_cb",
+                                  &Options::clearPreOnPlayEnabled,
+                                  &Options::setClearPreOnPlayEnabled);
+  registerOption<QCheckBox, bool>("customchat_cb",
+                                  &Options::customChatboxEnabled,
+                                  &Options::setCustomChatboxEnabled);
+  registerOption<QCheckBox, bool>("sticker_cb",
+                                  &Options::characterStickerEnabled,
+                                  &Options::setCharacterStickerEnabled);
+  registerOption<QCheckBox, bool>("continuous_cb",
+                                  &Options::continuousPlaybackEnabled,
+                                  &Options::setContinuousPlaybackEnabled);
+  registerOption<QCheckBox, bool>("category_stop_cb",
+                                  &Options::stopMusicOnCategoryEnabled,
+                                  &Options::setStopMusicOnCategoryEnabled);
+  registerOption<QCheckBox, bool>("sfx_on_idle_cb",
+                                  &Options::playSelectedSFXOnIdle,
+                                  &Options::setPlaySelectedSFXOnIdle);
+  registerOption<QCheckBox, bool>("evidence_double_click_cb",
+                                  &Options::evidenceDoubleClickEdit,
+                                  &Options::setEvidenceDoubleClickEdit);
+
+  // Callwords tab. This could just be a QLineEdit, but no, we decided to allow
+  // people to put a billion entries in.
+  FROM_UI(QPlainTextEdit, callwords_textbox)
+  registerOption<QPlainTextEdit, QStringList>(
+      "callwords_textbox", &Options::callwords, &Options::setCallwords);
+
+  // Audio tab.
+  FROM_UI(QComboBox, audio_device_combobox)
+  populateAudioDevices();
+  registerOption<QComboBox, QString>("audio_device_combobox",
+                                     &Options::audioOutputDevice,
+                                     &Options::setAudioOutputDevice);
+
+  FROM_UI(QSpinBox, suppress_audio_spinbox)
+  FROM_UI(QSpinBox, bliprate_spinbox)
+  FROM_UI(QCheckBox, blank_blips_cb)
+  FROM_UI(QCheckBox, loopsfx_cb)
+  FROM_UI(QCheckBox, objectmusic_cb)
+  FROM_UI(QCheckBox, disablestreams_cb)
+
+  registerOption<QSpinBox, int>("suppress_audio_spinbox",
+                                &::Options::defaultSuppressAudio,
+                                &Options::setDefaultSupressedAudio);
+  registerOption<QSpinBox, int>("bliprate_spinbox", &::Options::blipRate,
+                                &Options::setBlipRate);
+  registerOption<QCheckBox, bool>("blank_blips_cb", &Options::blankBlip,
+                                  &Options::setBlankBlip);
+  registerOption<QCheckBox, bool>("loopsfx_cb", &Options::loopingSfx,
+                                  &Options::setLoopingSfx);
+  registerOption<QCheckBox, bool>("objectmusic_cb",
+                                  &Options::objectionStopMusic,
+                                  &Options::setObjectionStopMusic);
+  registerOption<QCheckBox, bool>("disablestreams_cb",
+                                  &Options::streamingEnabled,
+                                  &Options::setStreamingEnabled);
+
+  // Asset tab
+  FROM_UI(QListWidget, mount_list)
+  auto *defaultMount =
+      new QListWidgetItem(tr("%1 (default)").arg(get_base_path()));
+  defaultMount->setFlags(Qt::ItemFlag::NoItemFlags);
+  ui_mount_list->addItem(defaultMount);
+  registerOption<QListWidget, QStringList>("mount_list", &Options::mountPaths,
+                                           &Options::setMountPaths);
+
+  FROM_UI(QPushButton, mount_add)
+  connect(ui_mount_add, &QPushButton::clicked, this, [this] {
+    QString path = QFileDialog::getExistingDirectory(
+        this, tr("Select a base folder"), QApplication::applicationDirPath(),
+        QFileDialog::ShowDirsOnly);
+    if (path.isEmpty()) {
+      return;
+    }
+    QDir dir(QApplication::applicationDirPath());
+    QString relative = dir.relativeFilePath(path);
+    if (!relative.contains("../")) {
+      path = relative;
+    }
+    QListWidgetItem *dir_item = new QListWidgetItem(path);
+    ui_mount_list->addItem(dir_item);
+    ui_mount_list->setCurrentItem(dir_item);
+
+    // quick hack to update buttons
+    emit ui_mount_list->itemSelectionChanged();
+  });
+
+  FROM_UI(QPushButton, mount_remove)
+  connect(ui_mount_remove, &QPushButton::clicked, this, [this] {
+    auto selected = ui_mount_list->selectedItems();
+    if (selected.isEmpty()) return;
+    delete selected[0];
+    emit ui_mount_list->itemSelectionChanged();
+    asset_cache_dirty = true;
+  });
+
+  FROM_UI(QPushButton, mount_up)
+  connect(ui_mount_up, &QPushButton::clicked, this, [this] {
+    auto selected = ui_mount_list->selectedItems();
+    if (selected.isEmpty()) return;
+    auto *item = selected[0];
+    int row = ui_mount_list->row(item);
+    ui_mount_list->takeItem(row);
+    int new_row = qMax(1, row - 1);
+    ui_mount_list->insertItem(new_row, item);
+    ui_mount_list->setCurrentRow(new_row);
+    asset_cache_dirty = true;
+  });
+
+  FROM_UI(QPushButton, mount_down)
+  connect(ui_mount_down, &QPushButton::clicked, this, [this] {
+    auto selected = ui_mount_list->selectedItems();
+    if (selected.isEmpty()) return;
+    auto *item = selected[0];
+    int row = ui_mount_list->row(item);
+    ui_mount_list->takeItem(row);
+    int new_row = qMin(ui_mount_list->count() + 1, row + 1);
+    ui_mount_list->insertItem(new_row, item);
+    ui_mount_list->setCurrentRow(new_row);
+    asset_cache_dirty = true;
+  });
+
+  FROM_UI(QPushButton, mount_clear_cache)
+  connect(ui_mount_clear_cache, &QPushButton::clicked, this, [this] {
+    asset_cache_dirty = true;
+    ui_mount_clear_cache->setEnabled(false);
+  });
+
+  connect(ui_mount_list, &QListWidget::itemSelectionChanged, this, [this] {
+    auto selected_items = ui_mount_list->selectedItems();
+    bool row_selected = !ui_mount_list->selectedItems().isEmpty();
+    ui_mount_remove->setEnabled(row_selected);
+    ui_mount_up->setEnabled(row_selected);
+    ui_mount_down->setEnabled(row_selected);
+
+    if (!row_selected) return;
+
+    int row = ui_mount_list->row(selected_items[0]);
+    if (row <= 1) ui_mount_up->setEnabled(false);
+    if (row >= ui_mount_list->count() - 1) ui_mount_down->setEnabled(false);
+  });
+
+  // Logging tab
+  FROM_UI(QCheckBox, downwards_cb)
+  FROM_UI(QSpinBox, length_spinbox)
+  FROM_UI(QCheckBox, log_newline_cb)
+  FROM_UI(QSpinBox, log_margin_spinbox)
+  FROM_UI(QLabel, log_timestamp_format_lbl)
+  FROM_UI(QComboBox, log_timestamp_format_combobox)
+
+  registerOption<QCheckBox, bool>("downwards_cb",
+                                  &Options::logDirectionDownwards,
+                                  &Options::setLogDirectionDownwards);
+  registerOption<QSpinBox, int>("length_spinbox", &Options::maxLogSize,
+                                &Options::setMaxLogSize);
+  registerOption<QCheckBox, bool>("log_newline_cb", &Options::logNewline,
+                                  &Options::setLogNewline);
+  registerOption<QSpinBox, int>("log_margin_spinbox", &Options::logMargin,
+                                &Options::setLogMargin);
+
+  FROM_UI(QCheckBox, log_timestamp_cb)
+  registerOption<QCheckBox, bool>("log_timestamp_cb",
+                                  &Options::logTimestampEnabled,
+                                  &Options::setLogTimestampEnabled);
+  connect(ui_log_timestamp_cb, &QCheckBox::stateChanged, this,
+          &::AOOptionsDialog::timestampCbChanged);
+  ui_log_timestamp_format_lbl->setText(
+      tr("Log timestamp format:\n") +
+      QDateTime::currentDateTime().toString(
+          Options::getInstance().logTimestampFormat()));
+
+  FROM_UI(QComboBox, log_timestamp_format_combobox)
+  registerOption<QComboBox, QString>("log_timestamp_format_combobox",
+                                     &Options::logTimestampFormat,
+                                     &Options::setLogTimestampFormat);
+  connect(ui_log_timestamp_format_combobox, &QComboBox::currentTextChanged,
+          this, &::AOOptionsDialog::onTimestampFormatEdited);
+
+  QString l_current_format = Options::getInstance().logTimestampFormat();
+
+  ui_log_timestamp_format_combobox->setCurrentText(l_current_format);
+
+  if (!Options::getInstance().logTimestampEnabled()) {
+    ui_log_timestamp_format_combobox->setDisabled(true);
+  }
+
+  FROM_UI(QCheckBox, log_ic_actions_cb)
+  FROM_UI(QCheckBox, desync_logs_cb)
+  FROM_UI(QCheckBox, log_text_cb)
+
+  registerOption<QCheckBox, bool>("log_ic_actions_cb", &Options::logIcActions,
+                                  &Options::setLogIcActions);
+  registerOption<QCheckBox, bool>("desync_logs_cb",
+                                  &Options::desynchronisedLogsEnabled,
+                                  &Options::setDesynchronisedLogsEnabled);
+  registerOption<QCheckBox, bool>("log_text_cb", &Options::logToTextFileEnabled,
+                                  &Options::setLogToTextFileEnabled);
+  registerOption<QCheckBox, bool>("log_demo_cb", &Options::logToDemoFileEnabled,
+                                  &Options::setLogToDemoFileEnabled);
+
+  // DSGVO/Privacy tab
+
+  FROM_UI(QTextBrowser, privacy_policy)
+  ui_privacy_policy->setPlainText(tr("Getting privacy policy..."));
+
+  updateValues();
+}
+
+void AOOptionsDialog::onTimestampFormatEdited()
+{
+  ui_log_timestamp_format_lbl->setText(
+      tr("Log timestamp format:\n") +
+      QDateTime::currentDateTime().toString(
+          ui_log_timestamp_format_combobox->currentText()));
+}
+
+void AOOptionsDialog::timestampCbChanged(int state)
+{
+  ui_log_timestamp_format_combobox->setDisabled(state == 0);
+}
+
+#if (defined(_WIN32) || defined(_WIN64))
+bool AOOptionsDialog::needsDefaultAudioDevice() { return true; }
+#elif (defined(LINUX) || defined(__linux__))
+bool AOOptionsDialog::needsDefaultAudioDevice() { return false; }
+#elif defined __APPLE__
+bool AOOptionsDialog::needsDefaultAudioDevice() { return true; }
+#else
+#error This operating system is not supported.
+#endif